Skip to content

Fix: expand imported type aliases in provider checks - #266

Merged
alies-dev merged 60 commits into
psalm:masterfrom
alies-dev:fix/249-type-alias-params
Nov 10, 2026
Merged

Fix: expand imported type aliases in provider checks#266
alies-dev merged 60 commits into
psalm:masterfrom
alies-dev:fix/249-type-alias-params

Conversation

@alies-dev

@alies-dev alies-dev commented Nov 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

A test parameter typed with an imported type alias is compared with the provider's datasets without expanding the alias, so the message names type-alias(...) and differs from the same parameter typed with the shape.

Before

/** @psalm-type Options = array{host: string} */
final class Connection {}

/** @psalm-import-type Options from Connection */
final class MyTestCase extends TestCase {
    /**
     * @return list<array{array<string, string>}>
     * @psalm-pure
     */
    public static function provide(): array {
        return [[['host' => 'x']]];
    }

    /**
     * @param Options $options
     */
    #[DataProvider('provide')]
    public function testAlias(array $options): void { // InvalidArgument: Argument 1 of NS\MyTestCase::testAlias expects type-alias(NS\Connection::Options), array<string, string> provided by NS\MyTestCase::provide():(list<list{array<string, string>}>)
        $this->assertSame('x', $options['host']);
    }
}

After

    public function testAlias(array $options): void { // ArgumentTypeCoercion: Argument 1 of NS\MyTestCase::testAlias expects array{host: string}, but parent type array<string, string> provided by NS\MyTestCase::provide():(list<list{array<string, string>}>)

self in a trait's provider and test types is resolved to the class using the trait.

Fixes #249

@alies-dev
fix(dead-code): mark PHPUnit hook methods as used psalm#251
37a7dc6
@alies-dev
fix(provider): report argument type coercion like Psalm core psalm#248
9de65a6
@alies-dev
fix(missing-constructor): honour setUp/#[Before] from traits psalm#252
fed591d
@alies-dev
fix(provider): check datasets of iterable<V> providers psalm#246
1bbc943
@alies-dev
fix(provider): expand type aliases of test params in dataset checks p…
dfbb7d5 
…salm#249
@alies-dev
fix(tests): ignore non-public methods as tests psalm#250
34b5864
@alies-dev
Merge remote-tracking branch 'origin/master' into fix/246-iterable-key
1830729 
# Conflicts:
#	tests/acceptance/TestCase.feature
@alies-dev
Merge remote-tracking branch 'origin/master' into fix/248-argument-co…
e943a07 
…ercion

# Conflicts:
#	tests/acceptance/TestCase.feature
@alies-dev
Merge remote-tracking branch 'origin/master' into fix/249-type-alias-…
eb1c10f 
…params

# Conflicts:
#	tests/acceptance/TestCase.feature
@alies-dev
Merge remote-tracking branch 'origin/master' into fix/251-hook-methods
c9cf83c 
# Conflicts:
#	tests/acceptance/TestCase.feature
@alies-dev
Merge remote-tracking branch 'origin/master' into fix/252-trait-initi…
4bc80b0 
…alizers

# Conflicts:
#	tests/acceptance/TestCase.feature
@alies-dev
Merge remote-tracking branch 'origin/master' into fix/250-non-public-…
4201b14 
…tests

# Conflicts:
#	tests/acceptance/TestCase.feature
@alies-dev
fix(dataset): accept open list datasets for further parameters psalm#247
4690926
@alies-dev
Merge remote-tracking branch 'origin/master' into fix/247-list-datasets
0827710 
# Conflicts:
#	tests/acceptance/TestCase.feature
@alies-dev
refactor(dead-code): simplify hook detection, cover attribute precede…
04c337e 
…nce psalm#251
@alies-dev
fix(provider): simplify mixed key exemption, add guard scenarios psal…
b0f403c 
…m#246
@alies-dev
fix(provider): resolve trait visibility of tests via appearing class p…
d858042 
…salm#250
@alies-dev
fix(provider): keep null/false findings next to coercion psalm#248
a76ca27
@alies-dev
fix(provider): keep open list tails to arity and dependency bounds ps…
93b10a1 
…alm#247
@alies-dev
fix(missing-constructor): walk each used trait once psalm#252
cb0517b
@alies-dev
style: apply phpcs fixes psalm#248
9ec927f
@alies-dev
style: apply phpcs fixes psalm#252
5775d50
@alies-dev
fix(provider): expand self and aliases in provider checks per class p…
97fcded 
…salm#249
@alies-dev
fix(provider): accept any class name string when expanding types psal…
a1962eb 
…m#249
@alies-dev
Merge remote-tracking branch 'origin/master' into fix/246-iterable-key
253858c
@alies-dev
Merge remote-tracking branch 'origin/master' into fix/247-list-datasets
6cf9f30
@alies-dev
Merge remote-tracking branch 'origin/master' into fix/248-argument-co…
54b131b 
…ercion
@alies-dev
Merge remote-tracking branch 'origin/master' into fix/249-type-alias-…
eccbc05 
…params
@alies-dev
Merge remote-tracking branch 'origin/master' into fix/250-non-public-…
b313f63 
…tests
@alies-dev
Merge remote-tracking branch 'origin/master' into fix/251-hook-methods
6f28e88
@alies-dev
Merge branch 'fix/252-trait-initializers' into fix/250-non-public-tests
3e459c8 
# Conflicts:
#	src/Hooks/TestCaseHandler.php
@alies-dev
Merge branch 'fix/250-non-public-tests' into fix/246-iterable-key
255f3ef
@alies-dev
Merge branch 'fix/246-iterable-key' into fix/247-list-datasets
24a3be0
@alies-dev
Merge branch 'fix/247-list-datasets' into fix/248-argument-coercion
dc348c0 
# Conflicts:
#	tests/acceptance/Datasets.feature
@alies-dev
Merge branch 'fix/248-argument-coercion' into fix/249-type-alias-params
1f99b40 
# Conflicts:
#	src/Hooks/TestCaseHandler.php
#	tests/acceptance/Datasets.feature
@alies-dev
test(provider): expect coercion for alias datasets after psalm#248 ps…
94bf8f9 
…alm#249
@alies-dev
Merge remote-tracking branch 'origin/master' into fix/251-hook-methods
f0a5065
@alies-dev
Merge branch 'fix/251-hook-methods' into fix/252-trait-initializers
b1bb6ce
@alies-dev
Merge branch 'fix/252-trait-initializers' into fix/250-non-public-tests
42cec42 
# Conflicts:
#	src/Hooks/TestCaseHandler.php
#	tests/acceptance/DataProviders.feature
@alies-dev
Merge branch 'fix/250-non-public-tests' into fix/246-iterable-key
8c526d9 
# Conflicts:
#	tests/acceptance/ProviderReturnTypes.feature
@alies-dev
Merge branch 'fix/246-iterable-key' into fix/247-list-datasets
df69574 
# Conflicts:
#	tests/acceptance/Datasets.feature
@alies-dev
Merge branch 'fix/247-list-datasets' into fix/248-argument-coercion
bd5eafa 
# Conflicts:
#	tests/acceptance/Datasets.feature
@alies-dev
test(provider): honour suppressions of argument coercions psalm#248
610c069
@alies-dev
Merge branch 'fix/248-argument-coercion' into fix/249-type-alias-params
2c5dfb6 
# Conflicts:
#	tests/acceptance/Datasets.feature
@alies-dev
Reuse the computed specials to detect hook methods
b466cdf
@alies-dev
Find initializers through the methods Psalm merged into the class
dccbc07 
Psalm has resolved parents, traits, aliases and insteadof into declaring_method_ids by AfterCodebasePopulated, so a setUp() not declared by TestCase or a #[Before] method of any declaring class is an initializer. This replaces the manual trait walk, the setUp alias special case and the descendant loop.
@alies-dev
Build the provider argument messages once
b236802
@alies-dev
Share the self/static expansion of provider types with the narrowing …
8d89598 
…handler
@alies-dev
Merge remote-tracking branch 'origin/master' into fix/251-hook-methods
54dcf04 
# Conflicts:
#	tests/acceptance/DeadCode.feature
@alies-dev
Use the required parameter count Psalm already records
5117aab
@alies-dev
Merge branch 'fix/251-hook-methods' into fix/252-trait-initializers
b44d005 
# Conflicts:
#	tests/acceptance/Initializers.feature
@alies-dev
Merge remote-tracking branch 'origin/master' into fix/252-trait-initi…
a8c4844 
…alizers
@alies-dev
Merge branch 'fix/252-trait-initializers' into fix/250-non-public-tests
fa633f2 
Check the test name before the method visibility.
@alies-dev
Merge branch 'fix/250-non-public-tests' into fix/246-iterable-key
5d4eaf9
@alies-dev
Merge branch 'fix/246-iterable-key' into fix/247-list-datasets
1c4dc51
@alies-dev
Merge branch 'fix/247-list-datasets' into fix/248-argument-coercion
da902aa
@alies-dev
Merge branch 'fix/248-argument-coercion' into fix/249-type-alias-params
fedcb7c 
# Conflicts:
#	src/Hooks/TestCaseHandler.php
@alies-dev
Merge remote-tracking branch 'origin/master' into fix/249-type-alias-…
aa8dfec 
…params

# Conflicts:
#	src/Hooks/TestCaseHandler.php
#	tests/acceptance/Datasets.feature
@alies-dev
alies-dev merged commit 7258e8a into psalm:master Nov 10, 2026
8 checks passed
@alies-dev
alies-dev deleted the fix/249-type-alias-params branch November 10, 2026 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Imported type aliases in test parameters are not expanded in provider checks

1 participant

@alies-dev